Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stretchable icons don't work as regular icons #9043

Closed
ansis opened this issue Nov 28, 2019 · 0 comments · Fixed by #9045
Closed

stretchable icons don't work as regular icons #9043

ansis opened this issue Nov 28, 2019 · 0 comments · Fixed by #9045
Labels
bug 🐞

Comments

@ansis
Copy link
Contributor

ansis commented Nov 28, 2019

mapbox-gl-js version: master

browser: all

Steps to Trigger Behavior

  1. use a stretchable icon without icon-text-fit

Link to Demonstration

Failing render test: https://github.com/mapbox/mapbox-gl-js/tree/icon-image-stretchable-failing

Expected Behavior

expected

Actual Behavior

actual
diff

Also add tests for:

  • icons with content being used as regular icons
  • stretchable icons with "icon-text-fit": "width" and "icon-text-fit": "vertical"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make stretchable images work with icon-text-fit: none mapbox/mapbox-gl-js
1 participant
@ansis