line-pattern soft breaking change ahead

[karimnaaji]

We are about to approve and go forward with #9266.

To recap the discussions considering our current options; some of styling might have been designed with the current behavior in mind and changing it might lead to different results. To anticipate the confusion of the new behavior, we will make sure to provide a clear changelog entry and express our reasoning behind it.

We will eventually require to introduce new stylespec options to express different ways of wrapping textures and patterns, but for the time being and to give more consistent behavior to our users with the current spec, we will go forward and introduce a soft visual breaking change.

If anyone is concerned about their styles using line-patterns, please share them here here so we can provide thorough guidance and support for the transition.

The steps to transition would require the following:

1. Compare your style in the new version of the build, is the new behavior of lines using line-pattern desired for your case? If not:
2. Look whether any of your image pattern is clipped (any case where the width of the line is smaller than the pattern attached to it)
3. For each of these lines revisit your asset in order to clip the pattern to match the previous behavior

To better understand the visual differences between the change the old and new behavior, make sure to look at the new baselines for the render tests in #9266.

For other contacts make sure to either tag @chloekraw , @ansis or @karimnaaji !

[Plantain]

Would this change be causing graphical distortions with fill-pattern?
With a fill-pattern layer, zooming now is causing chaotic distortive behaviour like pictured:
a

Worked fine in 1.8.1, broken in 1.9.0-beta1.

Previously it zoomed linearly (like the map) when zooming:

[karimnaaji]

That seems like a different issue, possibly related to #9479, we may have an incorrect data layout bug we are currently tracking. Can you post how you are adding the image and what styling rules you are using for this layer?

[xfpopxf]

[xfpopxf]

line-pattern Image capping problem

[xfpopxf]