From e51454ba3398c42ab0dd8cdd91649b1f54c645da Mon Sep 17 00:00:00 2001 From: Andrew Hay Kurtz Date: Mon, 25 Nov 2019 14:39:25 -0800 Subject: [PATCH 1/3] Add changelog instructions to PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d66289995b6..a3035222322 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,3 +10,6 @@ - [ ] manually test the debug page - [ ] tagged `@mapbox/studio` and/or `@mapbox/maps-design` if this PR includes style spec or visual changes - [ ] tagged `@mapbox/gl-native` if this PR includes shader changes or needs a native port + - [ ] include changelog info + - [ ] add a changelog label ('bug', 'feature', 'docs', etc). Use the label 'skip changelog' to hide this PR in the changelog + - [ ] include a changelog entry. The PR title is used or optionaly a tagged `...` section in the body. From 53974ef21b613f1abb45f37a0076a0fafd8a061d Mon Sep 17 00:00:00 2001 From: Andrew Hay Kurtz Date: Tue, 26 Nov 2019 07:41:44 -0800 Subject: [PATCH 2/3] Update PULL_REQUEST_TEMPLATE.md Simplify new changelog related template wording --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a3035222322..80b08ec9546 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,6 +10,5 @@ - [ ] manually test the debug page - [ ] tagged `@mapbox/studio` and/or `@mapbox/maps-design` if this PR includes style spec or visual changes - [ ] tagged `@mapbox/gl-native` if this PR includes shader changes or needs a native port - - [ ] include changelog info - - [ ] add a changelog label ('bug', 'feature', 'docs', etc). Use the label 'skip changelog' to hide this PR in the changelog - - [ ] include a changelog entry. The PR title is used or optionaly a tagged `...` section in the body. + - [ ] add a changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog' + - [ ] include a changelog entry in the PR title or optionaly a tagged `...` section From 3a52b26fee1ed390555f2d68e8613dc9aca77d8c Mon Sep 17 00:00:00 2001 From: Andrew Hay Kurtz Date: Wed, 27 Nov 2019 13:42:41 -0800 Subject: [PATCH 3/3] Place optional changelog entry tags on own line --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 80b08ec9546..5f40cc7854e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,5 +10,5 @@ - [ ] manually test the debug page - [ ] tagged `@mapbox/studio` and/or `@mapbox/maps-design` if this PR includes style spec or visual changes - [ ] tagged `@mapbox/gl-native` if this PR includes shader changes or needs a native port - - [ ] add a changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog' - - [ ] include a changelog entry in the PR title or optionaly a tagged `...` section + - [ ] apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog' + - [ ] `...`