Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Test map views within different view controller hierarchies #302

Closed
jmkiley opened this issue May 14, 2019 · 3 comments
Closed

Test map views within different view controller hierarchies #302

jmkiley opened this issue May 14, 2019 · 3 comments
Assignees
Labels

Comments

@jmkiley
Copy link
Contributor

jmkiley commented May 14, 2019

We should include more integration tests to monitor how MGLMapView interacts within different view and view controller hierarchies. These tests will live in the Integration Test Harness.

The tests should measure MGLMapView performance:

  • Within a UITabBarController, UIScrollView, UITableViewController, modally presented view controller and UINavigationBarController.
  • Present a modal view controller over the map view.
  • As a view that gets larger/smaller based on an action.
  • Under a drawer view.

As part of this work, we should also look at subviews within MGLMapView, such as custom annotation views and the attribution button.

The tests on the map view itself will be consistent for the most part. Some ideas for things to test:

Related: mapbox/mapbox-gl-native#14516

cc @julianrex @chloekraw

@jmkiley jmkiley self-assigned this May 14, 2019
@stale
Copy link

stale bot commented Nov 10, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 10, 2019
@chloekraw chloekraw reopened this Nov 10, 2019
@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed May 9, 2020
@chloekraw chloekraw reopened this May 9, 2020
@chloekraw chloekraw transferred this issue from mapbox/mapbox-gl-native May 9, 2020
@stale stale bot added the archived label Nov 7, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants