Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add contentInsetAdjustmentBehavior property to MGLMapView #12143

Closed
1ec5 opened this issue Jun 13, 2018 · 3 comments
Closed

Add contentInsetAdjustmentBehavior property to MGLMapView #12143

1ec5 opened this issue Jun 13, 2018 · 3 comments
Labels
archived Archived because of inactivity gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 13, 2018

In iOS 11.0, UIViewController.automaticallyAdjustsScrollViewInsets is deprecated in favor of UIScrollView.contentInsetAdjustmentBehavior. automaticallyAdjustsScrollViewInsets has always been a bit of a pain for us, versus how macOS handles the same configuration option, because it’s a property on the containing view controller instead of the view itself. (We have to crawl up the responder chain looking for the view controller just to update MGLMapView’s internal constraints.) MGLMapView should implement its own contentInsetAdjustmentBehavior property that lets the developer indicate whether the MGLMapView itself should adjust the insets automatically.

We’ll have to keep support for UIViewController.automaticallyAdjustsScrollViewInsets around until that property is removed from the (Apple) iOS SDK, in case any developer depends on the currently documented behavior.

/ref #12142 #10485
/cc @friedbunny @julianrex

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS labels Jun 13, 2018
@frederoni frederoni mentioned this issue Jun 14, 2018
2 tasks
@stale stale bot added the archived Archived because of inactivity label Dec 11, 2018
@stale
Copy link

stale bot commented Dec 11, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 11, 2018
@julianrex julianrex reopened this Dec 11, 2018
@stale stale bot removed the archived Archived because of inactivity label Dec 11, 2018
@stale stale bot added the archived Archived because of inactivity label Jun 9, 2019
@stale
Copy link

stale bot commented Jun 9, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Jun 9, 2019
@julianrex julianrex reopened this Jun 10, 2019
@stale stale bot removed the archived Archived because of inactivity label Jun 10, 2019
@stale stale bot added the archived Archived because of inactivity label Jul 29, 2020
@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor
Projects
None yet
Development

No branches or pull requests

3 participants