Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rotation flick animation support (iOS). #1338

Closed
mb12 opened this issue Apr 24, 2015 · 5 comments
Closed

Rotation flick animation support (iOS). #1338

mb12 opened this issue Apr 24, 2015 · 5 comments

Comments

@mb12
Copy link

mb12 commented Apr 24, 2015

Is there any plan to add support for rotation flick animation in Mapbox GL? By rotation flick, I mean the map continues to rotate even after one takes the fingers off screen.

@1ec5
Copy link
Contributor

1ec5 commented Apr 24, 2015

#1292 adds rotation drift. It doesn't rotate forever; it's similar to what MapKit does when you rotate quickly. Is that what you mean?

@mb12
Copy link
Author

mb12 commented Apr 24, 2015

Yes, I do mean Mapkit kind of rotation drift where in it sometimes does a full 360 turn upon rotation before it comes to a stop.

@1ec5
Copy link
Contributor

1ec5 commented Apr 24, 2015

The implementation in #1292 will always drift for one second, spinning by an angle that depends on the angular velocity at the end of the rotation gesture. It’s quite difficult to make it spin a full 360°. The animation is perhaps more conservative than the ones for pan and pinch; I was afraid that an aggressive rotation animation would disorient the user. But please try out that PR and let me know of any improvements I should make.

@1ec5 1ec5 closed this as completed Apr 24, 2015
@mb12
Copy link
Author

mb12 commented May 8, 2015

I tried out the latest repo where in this change is already committed. Its almost impossible to trigger rotation drift like animation. It almost always detects it as a zoom.
Its very easy to trigger rotation drift in other vector map impls (Apple/Goog/Nokia).

@1ec5
Copy link
Contributor

1ec5 commented May 8, 2015

Its almost impossible to trigger rotation drift like animation. It almost always detects it as a zoom.

Agreed; can you file a new ticket? #1434 and #1436 should improve things on the gesture front, but we decided to lock things down to stability and performance fixes ahead of a beta release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants