Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move configuration of max/min zoomlevels #4018

Closed
3 tasks done
tobrun opened this issue Feb 18, 2016 · 2 comments · Fixed by #4022
Closed
3 tasks done

Move configuration of max/min zoomlevels #4018

tobrun opened this issue Feb 18, 2016 · 2 comments · Fixed by #4022
Assignees
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@tobrun
Copy link
Member

tobrun commented Feb 18, 2016

Max/Min zoomlevels have landend with #3712.
These are currently exposed as getters/setters on MapboxMap.
I feel these should be moved to UiSettings, that class seems more relevant for configuration.

Checklist:

  • move current implementation to UiSettings
  • update unit tests UiSettingsTest
  • expose configuration through MapView attributes attrs
@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Feb 18, 2016
@tobrun tobrun added this to the android-v4.0.0 milestone Feb 18, 2016
tobrun added a commit that referenced this issue Feb 18, 2016
@tobrun
Copy link
Member Author

tobrun commented Feb 18, 2016

When trying to add max and min zoom level as attributes. It seems that the resource identifier from #3119 is also required in attrs. Will update with this issue.

@tobrun
Copy link
Member Author

tobrun commented Feb 18, 2016

I created a separate ticket for above in #4021, I'm going to add the attrs in the old fashion for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants