Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Various class methods should be class properties #6778

Closed
1ec5 opened this issue Oct 21, 2016 · 2 comments
Closed

Various class methods should be class properties #6778

1ec5 opened this issue Oct 21, 2016 · 2 comments
Assignees
@friedbunny
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Milestone
ios-v4.0.0-boba

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 21, 2016 •
edited
Loading

Various methods like +[MGLStyle streetsStyleURL], +[MGLAccountManager accessToken]/+[MGLAccountManager setAccessToken:], and +[MGLOfflineStorage sharedOfflineStorage] should be class properties with refined Swift names (#5178). Swift code would be able to say:

MGLOfflineStorage.shared.addPack(…

Once #6386 is fixed, Swift code would be able to say:

mapView.style = .streets

This change will require anyone compiling or building or using the SDK in another project to use Xcode 8.0 or above. It would also require a major version bump if we aren’t able to keep the old methods around as deprecated aliases.

/cc @friedbunny @frederoni
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS labels Oct 21, 2016
@friedbunny friedbunny added this to the ios-future milestone Oct 21, 2016
@friedbunny
Copy link
Contributor

Agreed, this would be a good change.

@lilykaiser lilykaiser removed this from the ios-future milestone Nov 15, 2017
@lilykaiser lilykaiser added this to the ios-v4.0.0 milestone Apr 11, 2018
@friedbunny friedbunny added the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Apr 12, 2018
@friedbunny friedbunny mentioned this issue Apr 12, 2018
Merged
4 tasks
@1ec5 1ec5 mentioned this issue Apr 16, 2018
Merged
3 tasks
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 16, 2018

Fixed in #11674 on the release-boba branch for iOS map SDK v4.0.0 and macOS map SDK v0.7.0.

@1ec5 1ec5 closed this as completed Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@friedbunny friedbunny

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Milestone
ios-v4.0.0-boba
Development

No branches or pull requests
3 participants
@friedbunny @1ec5 @lilykaiser