Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster route does not guarantee new route is different #3144

Closed
kmadsen opened this issue Jun 10, 2020 · 1 comment · Fixed by #3301
Closed

Faster route does not guarantee new route is different #3144

kmadsen opened this issue Jun 10, 2020 · 1 comment · Fixed by #3301

Comments

@kmadsen
Copy link
Contributor

kmadsen commented Jun 10, 2020

Looking again at the code for faster route, and I'm not seeing where we're checking if the new route is actually different. How do we know, that the new route is not the current route with a significantly faster time?

Tests for the faster route controller are only checking if durationRemaining() is faster, but not if the route is different

MapboxDirectionsSession.requestFasterRoute is making a regular request to directions. It does not check if the new route is different.

Maybe it is the adjustedRouteOptions? But it only removes the origin and waypoints that have been completed.

@Guardiola31337
Copy link
Contributor

Refs. #3116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants