Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice instruction milestone crash #834

Closed
Guardiola31337 opened this issue Apr 6, 2018 · 0 comments
Closed

Voice instruction milestone crash #834

Guardiola31337 opened this issue Apr 6, 2018 · 0 comments
Assignees
Labels
bug Defect to be fixed. release blocker Needs to be resolved before the release.
Milestone

Comments

@Guardiola31337
Copy link
Contributor

While working on #697 found 👇

voiceinstructionmilestoneissue

04-06 20:55:13.803 25521-25704/? E/AndroidRuntime: FATAL EXCEPTION: NavThread
                                                   Process: com.mapbox.services.android.navigation.testapp, PID: 25521
                                                   java.lang.NullPointerException: Attempt to invoke virtual method 'void com.mapbox.services.android.navigation.v5.navigation.VoiceInstructionLoader.cacheInstructions(com.mapbox.services.android.navigation.v5.routeprogress.RouteProgress, boolean)' on a null object reference
                                                       at com.mapbox.services.android.navigation.v5.milestone.VoiceInstructionMilestone.isOccurring(VoiceInstructionMilestone.java:30)
                                                       at com.mapbox.services.android.navigation.v5.navigation.NavigationHelper.checkMilestones(NavigationHelper.java:201)
                                                       at com.mapbox.services.android.navigation.v5.navigation.NavigationEngine.handleRequest(NavigationEngine.java:76)
                                                       at com.mapbox.services.android.navigation.v5.navigation.NavigationEngine.handleMessage(NavigationEngine.java:41)
                                                       at android.os.Handler.dispatchMessage(Handler.java:98)
                                                       at android.os.Looper.loop(Looper.java:148)
                                                       at android.os.HandlerThread.run(HandlerThread.java:61)

Steps to trigger behavior

  1. Navigation test app (dan-maps-3.0 branch)
  2. Open Mock Navigation activity
  3. Tap map to place waypoint
  4. Press the START ROUTE button
  5. 💥

It seems that VoiceInstructionLoader from VoiceInstructionMilestone is not properly initialized because if you launch a navigation session from the Navigation Views activity and then repeat above steps it works fine. Noting that VoiceInstructionLoader is a singleton and Mock Navigation activity doesn't reproduce voice instructions.

👀 @devotaaabel @danesfeder

@Guardiola31337 Guardiola31337 added bug Defect to be fixed. topic: instructions labels Apr 6, 2018
@akitchen akitchen added the release blocker Needs to be resolved before the release. label Apr 9, 2018
@devotaaabel devotaaabel self-assigned this Apr 11, 2018
@danesfeder danesfeder added this to the v0.13.0 milestone Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed. release blocker Needs to be resolved before the release.
Projects
None yet
Development

No branches or pull requests

4 participants