Add tunnels functionality #1392

Guardiola31337 · 2018-10-04T13:33:21Z

Fixes #835

Adds tunnels functionality
- ~~Adds a new option (TunnelListener) to NavigationViewOptions~~
  - Should we expose new APIs in MapboxNavigation for adding / removing this listener? Or even remove this listener altogether? Currently it's possible to get the same inTunnel information attaching to ProgressChangeListener and querying the RouteProgress 👀
    
    mapbox-navigation-android/app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/RerouteActivity.java
    
    Line 218 in 9c8d687
    
    boolean inTunnel = routeProgress.inTunnel();
    
    Is this adding a duplicated behavior or making the API more friendly? Thoughts @danesfeder @devotaaabel? 👉 Add tunnels functionality #1392 (comment)
- The SDK doesn't change day-night mode automatically anymore. Clients should be responsible of this moving forward. We 👀 if isNightModeEnabled and set the theme accordingly though. Kinda revert Use theme attribute to update MapView map style URL #1018
- Adds day-night mode (UI) switching when entering / exiting a tunnel to some examples from the test app in order to showcase how to implement that behavior from a client point of view

TODOs

Noticed that in the EmbeddedNavigationActivity and FragmentNavigationActivity examples from the test app voice instructions are "duplicated" after recreating the Activity

Guardiola31337 · 2018-10-04T17:02:10Z

Adds a new option (TunnelListener) to NavigationViewOptions

Should we expose new APIs in MapboxNavigation for adding / removing this listener? Or even remove this listener altogether? Currently it's possible to get the same inTunnel information attaching to ProgressChangeListener and querying the RouteProgress 👀

mapbox-navigation-android/app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/RerouteActivity.java

Line 218 in 9c8d687

boolean inTunnel = routeProgress.inTunnel();

Is this adding a duplicated behavior or making the API more friendly? Thoughts @danesfeder @devotaaabel?

In order to keep this as simple as possible I went ahead and removed the TunnelListener option altogether. That means, less confusion to clients and less complexity on our side - avoiding any tech debt that this might cause.

I've edited OP to reflect this.

cc @danesfeder @devotaaabel

danesfeder

@Guardiola31337 this is looking good, but I was wondering, would it be a good idea to contain all of the client logic needed for setting up night mode in a public class that they may use? Just a thought, I think it would make developers' lives a lot easier if we included something like this that they could use in their Activity or Fragment

danesfeder · 2018-10-04T19:38:36Z

...ox/services/android/navigation/testapp/activity/navigationui/EmbeddedNavigationActivity.java

@@ -132,6 +132,7 @@ protected void onDestroy() {
    navigationView.onDestroy();
    if (isFinishing()) {
      saveNightModeToPreferences(AppCompatDelegate.MODE_NIGHT_AUTO);
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_AUTO);


Does setting this before the Activity is destroyed still allow it to be considered on re-creation?

Yes it does. Mainly because this is "per app" and in the test app closing any activity redirects you to the MainActivity i.e. the night mode is kept if you reopen the Activity.

Guardiola31337 · 2018-10-08T11:19:46Z

@danesfeder

would it be a good idea to contain all of the client logic needed for setting up night mode in a public class that they may use? Just a thought, I think it would make developers' lives a lot easier if we included something like this that they could use in their Activity or Fragment

IMO If you're referring to extracting the AppCompatDelegate.setDefaultNightMode and the SharedPreferences related code, these are Android implementation details so I don't see a great benefit of exposing from our side. In any case, let me know what you'd include in that convenience class and we can discuss further.

Guardiola31337 · 2018-10-15T11:18:03Z

@danesfeder I followed up on all your comments / concerns / questions. Ready for another round 👀

danesfeder

@Guardiola31337 some minor cleanup / comments - this is looking good, thanks for addressing my questions.

danesfeder · 2018-10-16T13:10:17Z

app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/RerouteActivity.java

@@ -214,6 +215,15 @@ public void userOffRoute(Location location) {

  @Override
  public void onProgressChange(Location location, RouteProgress routeProgress) {
+    boolean inTunnel = routeProgress.inTunnel();


This chunk of logic can be extracted into a private method. Maybe we can think of better naming for isInTunnel vs. inTunnel - it's a little confusing to determine which variable is coming from where.

danesfeder · 2018-10-16T13:11:05Z

...x/services/android/navigation/testapp/activity/navigationui/fragment/NavigationFragment.java

@@ -44,6 +52,11 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
  @Override
  public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
    super.onViewCreated(view, savedInstanceState);
+    if (wasNavigationStopped()) {


For readability when the Fragment is being created, this can be extracted into a private method

danesfeder · 2018-10-16T13:12:41Z

...x/services/android/navigation/testapp/activity/navigationui/fragment/NavigationFragment.java

+  @Override
+  public void onProgressChange(Location location, RouteProgress routeProgress) {
+    boolean isInTunnel = routeProgress.inTunnel();
+    boolean wasInTunnel = wasInTunnel();


I like the variable naming here - if possible, let's us the same naming in RerouteActivity

Guardiola31337 · 2018-10-16T13:29:47Z

@danesfeder this is updated and ready for another round 👀

danesfeder

@Guardiola31337 looks good, thanks for addressing the feedback

Guardiola31337 added ⚠️ DO NOT MERGE PR should not be merged! ✓ ready for review needs discussion Can't be started in current state, needs clarification. labels Oct 4, 2018

Guardiola31337 self-assigned this Oct 4, 2018

Guardiola31337 requested review from danesfeder and devotaaabel October 4, 2018 13:33

Guardiola31337 force-pushed the pg-tunnels branch 2 times, most recently from 7d99640 to cdac640 Compare October 4, 2018 16:50

Guardiola31337 removed needs discussion Can't be started in current state, needs clarification. ⚠️ DO NOT MERGE PR should not be merged! labels Oct 4, 2018

danesfeder reviewed Oct 4, 2018

View reviewed changes

akitchen mentioned this pull request Oct 8, 2018

User should see themselves progress through tunnel when GPS is weak or nonexistent #835

Closed

6 tasks

Guardiola31337 force-pushed the pg-tunnels branch from cdac640 to 9ffada8 Compare October 15, 2018 11:12

danesfeder reviewed Oct 16, 2018

View reviewed changes

add tunnels functionality

0f031ac

Guardiola31337 force-pushed the pg-tunnels branch from 9ffada8 to 0f031ac Compare October 16, 2018 13:27

danesfeder approved these changes Oct 16, 2018

View reviewed changes

Guardiola31337 merged commit 8b57696 into master Oct 16, 2018

Guardiola31337 deleted the pg-tunnels branch October 16, 2018 13:43

This was referenced Oct 19, 2018

Fatal Exception: java.lang.IllegalArgumentException: Receiver not registered #1439

Closed

Release v0.22.0 #1458

Closed

boldtrn mentioned this pull request Feb 1, 2019

night mode graphhopper/graphhopper-navigation-example-legacy#37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tunnels functionality #1392

Add tunnels functionality #1392

Guardiola31337 commented Oct 4, 2018 •

edited

Loading

Guardiola31337 commented Oct 4, 2018

danesfeder left a comment

danesfeder Oct 4, 2018

Guardiola31337 Oct 8, 2018

Guardiola31337 commented Oct 8, 2018

Guardiola31337 commented Oct 15, 2018

danesfeder left a comment

danesfeder Oct 16, 2018

danesfeder Oct 16, 2018

danesfeder Oct 16, 2018

Guardiola31337 commented Oct 16, 2018

danesfeder left a comment

Add tunnels functionality #1392

Add tunnels functionality #1392

Conversation

Guardiola31337 commented Oct 4, 2018 • edited Loading

Guardiola31337 commented Oct 4, 2018

danesfeder left a comment

Choose a reason for hiding this comment

danesfeder Oct 4, 2018

Choose a reason for hiding this comment

Guardiola31337 Oct 8, 2018

Choose a reason for hiding this comment

Guardiola31337 commented Oct 8, 2018

Guardiola31337 commented Oct 15, 2018

danesfeder left a comment

Choose a reason for hiding this comment

danesfeder Oct 16, 2018

Choose a reason for hiding this comment

danesfeder Oct 16, 2018

Choose a reason for hiding this comment

danesfeder Oct 16, 2018

Choose a reason for hiding this comment

Guardiola31337 commented Oct 16, 2018

danesfeder left a comment

Choose a reason for hiding this comment

Guardiola31337 commented Oct 4, 2018 •

edited

Loading