Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to available styles on api.mapbox.cn endpoint #1564

Closed
1ec5 opened this issue Jul 18, 2018 · 2 comments
Closed

Default to available styles on api.mapbox.cn endpoint #1564

1ec5 opened this issue Jul 18, 2018 · 2 comments
Assignees
Labels
feature New feature request. topic: localization

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 18, 2018

The default day and night styles defined by this library’s MGLStyle extension should account for the different styles available on the .cn endpoint. Specifically, since the Mapbox Navigation Guidance Day/Night styles are currently unavailable on api.mapbox.cn, these methods should return the style URLs for Mapbox Streets Chinese (or Mapbox Light Chinese?) and Mapbox Dark Chinese, respectively.

public class var navigationGuidanceDayStyleURL: URL { get { return URL(string: "mapbox://styles/mapbox/navigation-guidance-day-v2")! } }

mapbox/mapbox-gl-native#12417 would make it easier to check the current API base URL. Until that feature is implemented, the API base URL is static anyways, so we can just consult the Bundle directly.

/cc @m-stephen

@m-stephen
Copy link
Contributor

m-stephen commented Jul 24, 2018

PR here.
/cc @suntony @chriswu42

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 25, 2018

Implemented in #1558.

@1ec5 1ec5 closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request. topic: localization
Projects
None yet
Development

No branches or pull requests

3 participants