Recommend bundling node-pre-gyp #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springmeyer
added a commit
to mapbox/carmen-cache
that referenced
this pull request
Mar 15, 2017
Moves to bundling as a best practice due to mapbox/node-pre-gyp#269
springmeyer
added a commit
to mapbox/carmen-cache
that referenced
this pull request
Apr 28, 2017
Moves to bundling as a best practice due to mapbox/node-pre-gyp#269
springmeyer
pushed a commit
to mapbox/node-cpp-skel
that referenced
this pull request
May 1, 2017
springmeyer
added a commit
to naturalatlas/node-gdal
that referenced
this pull request
Jun 5, 2017
Reverts 54199fb Adheres to best practices per mapbox/node-pre-gyp#269
springmeyer
added a commit
to naturalatlas/node-gdal
that referenced
this pull request
Jun 5, 2017
Reverts 54199fb Adheres to best practices per mapbox/node-pre-gyp#269
jdesboeufs
pushed a commit
to jdesboeufs/node-gdal
that referenced
this pull request
Aug 13, 2017
Reverts 54199fb Adheres to best practices per mapbox/node-pre-gyp#269
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Recommend bundling node-pre-gyp
liubomyr191
pushed a commit
to liubomyr191/gdal-with-node
that referenced
this pull request
Nov 9, 2024
Reverts 54199fb2bb463 Adheres to best practices per mapbox/node-pre-gyp#269
liubomyr191
pushed a commit
to liubomyr191/gdal-with-node
that referenced
this pull request
Nov 9, 2024
Reverts 54199fb2bb463 Adheres to best practices per mapbox/node-pre-gyp#269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences in how npm versions behave over time means that bundling node-pre-gyp is the most robust method to avoid install problems for modules that depend on node-pre-gup.
This changes docs back to what they originally recommended: to bundle
node-pre-gypat publish time rather that using apreinstallhook to installnode-pre-gypon the fly. This reverts #201 and addresses #260.