Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal vector tile C++ decoder and encoder #1

Closed
6 tasks done
springmeyer opened this issue Sep 10, 2017 · 2 comments
Closed
6 tasks done

Minimal vector tile C++ decoder and encoder #1

springmeyer opened this issue Sep 10, 2017 · 2 comments
Milestone

Comments

@springmeyer
Copy link
Contributor

springmeyer commented Sep 10, 2017

@joto has created a solid design for new, higher performance and more minimalistic vector tile decoder and encoder as part of mapbox/vector-tile#20. This vtzero repo will be the home for this work.

This implementation will only depend on protozero and will make no assumptions about the property, feature, or geometry storage you will decode into or encode from. Rather it will provide handlers for minimal geometry and property decoding and encoding. The https://github.com/mapbox/vector-tile will be re-written to be a higher level wrapper around vtzero for handling vtzero <-> geometry.hpp, projections, and other APIs that will depend on C++ modules in the mapbox:: namespace.

@joto - let's use this ticket for the initial coordination. The next steps I'm seeing are:

  • @springmeyer creates initial skeleton of repo based on hpp-skel from the @mapbox/core-tech team.
  • @joto reviews and pings @springmeyer if any of the skeleton needs modified in major ways
  • @joto tags latest protozero at 1.5.3 (as I think latest vtzero depends on it)
  • @springmeyer packages protozero 1.5.3 in mason
  • @springmeyer updates this repo to pull in protozero 1.5.3 - 19dc27e
  • @joto moves the vtzero code over from vector-tile to here.

After that there will still be much to do. Like writing tests, benchmarks, and docs (tracked in milestone 1). As well as back-porting fixes we make here that are appropriate for hpp-skel. But we can handle all those things in followup tickets.

@springmeyer
Copy link
Contributor Author

springmeyer commented Oct 13, 2017

This work is now done thanks to a huge lift by @joto and the @mapbox/core-tech team. Closing this now - next steps are better tests and docs:

@mapsam
Copy link
Contributor

mapsam commented Oct 13, 2017

tada-quack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants