You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@joto - I noticed that you are working on a more flexible way to control how the tables are built for keys and values during the building of a new vector tile.
I'd like to put a request in to prioritize this code for documentation and tests because I anticipate that @GretaCB and I will want to use it, and benchmark plugging in different containers.
Currently in our code I'm seeing that the default implementation (which appears to iterate the protobuf data each time a key/value is added?) is a bottleneck. So I'm hoping a hashmap will be faster:
@joto - I noticed that you are working on a more flexible way to control how the tables are built for keys and values during the building of a new vector tile.
The new interface I notice in https://github.com/mapbox/vtzero/blob/master/include/vtzero/index.hpp looks powerful - the idea of allowing the programmer to control whether a
std::map
orstd::unordered_map
(or something else like a sso optimized map - https://github.com/greg7mdp/sho) is used it excellent.I'd like to put a request in to prioritize this code for documentation and tests because I anticipate that @GretaCB and I will want to use it, and benchmark plugging in different containers.
Currently in our code I'm seeing that the default implementation (which appears to iterate the protobuf data each time a key/value is added?) is a bottleneck. So I'm hoping a hashmap will be faster:
refs
vtzero/include/vtzero/builder_impl.hpp
Lines 66 to 79 in 094cd4b
The text was updated successfully, but these errors were encountered: