Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carto branding is everywhere #26

Open
2 tasks
almereyda opened this issue Jul 10, 2018 · 7 comments
Open
2 tasks

Carto branding is everywhere #26

almereyda opened this issue Jul 10, 2018 · 7 comments

Comments

@almereyda
Copy link

almereyda commented Jul 10, 2018

When displaying a published map,

  • the bottom shows a Carto logo pointing at their site, and
  • the attribution reads © Carto.

This is loosely related to #24.

@kidwellj
Copy link
Member

That is a reference to the copyright on basemap tiles, I believe. Can you try using a different basemap and see if the attribution disappears? To be fair to Carto, if they've developed the basemap, it's only fair to provide attribution...

@almereyda
Copy link
Author

No, this is also shown for Stamen Toner backgrounds, and attributes those correctly.

@kidwellj
Copy link
Member

kidwellj commented Jul 10, 2018

Thanks for checking - I think I've found the issue (here: splashblot/dronedb#68, with original CartoDB commentary here: CartoDB/cartodb#6108). Can you check and see if it's resolved now?

@kidwellj
Copy link
Member

kidwellj commented Jul 10, 2018

For reference, fix I've applied was:

RAILS_ENV=production bundle exec rake cartodb:features:add_feature_flag[disabled_cartodb_logo]
RAILS_ENV=production bundle exec rake cartodb:features:enable_feature_for_all_users[disabled_cartodb_logo]

@almereyda
Copy link
Author

almereyda commented Jul 10, 2018

The map that I linked above still looks the same. Maybe one needs to apply a patch to the code somehow?

@kidwellj Could you try running it for the whole organisation, as exemplified in splashblot/dronedb#68 (comment) ?

@kidwellj
Copy link
Member

@almereyda Yep, have already tried for whole organisation. Might be necessary to push the platform to a new version before the rake feature will work. Realistically, I'm looking at running the next upgrade in October '18 or so...

@kidwellj
Copy link
Member

Opening new issue to track upgrade progress: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants