Fix missing speed #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vberthet Thank you for contributing this fix. Could you please restrict your PR to only the actual one-line fix in MapboxMapController.java? The other changes seem unrelated to this issue and are probably already addressed through the other merged PRs 😅 |
|
@vberthet I've resolved the merge conflicts locally. If you'd like me to push the merge commit you'd need to edit the settings for the PR to allow me that. (https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) If you'd rather do it yourself that is also fine, though! After the merge conflicts are resolved I'd love to merge this. |
vberthet
force-pushed
the
fix-missing-speed
branch
from
533868a
to
6c89802
Compare
vberthet
force-pushed
the
fix-missing-speed
branch
from
6c89802
to
db93ccc
Compare
|
@vberthet Perfect, thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with callback onUserLocationUpdated :
Speed attribute on UserLocation was allways null on android