Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature JSON encoding from .ascii to .utf8 #142

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Change feature JSON encoding from .ascii to .utf8 #142

merged 1 commit into from
Aug 5, 2022

Conversation

SunBro-Marko
Copy link
Contributor

Change feature JSON encoding from .ascii to .utf8

@SunBro-Marko
Change feature JSON encoding to .utf8
ef607ba 
- change feature JSON encoding from .ascii to .utf8
@SunBro-Marko
Copy link
Contributor Author

SunBro-Marko commented Aug 3, 2022 •
edited
Loading

Screenshot 2022-08-02 at 20 06 20
Sorry for my english.
In cases when we use this method on iOS, we get broken strings. This kills the ability to get data on the rendered feature. This problem shows itself only on iOS devices, there is no such problem in a similar code on android.

@SunBro-Marko
Copy link
Contributor Author

SunBro-Marko commented Aug 3, 2022 •
edited
Loading

Additional example of broken strings on IOS, and how it looks on android (It is from vector data Open Street Maps)
Screenshot 2022-08-03 at 01 46 29
Screenshot 2022-08-03 at 02 38 33

m0nac0
m0nac0 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@m0nac0 m0nac0 merged commit 102470b into maplibre:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nac0 m0nac0 m0nac0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunBro-Marko @m0nac0