-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all string to locale class #3621
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
- Coverage 87.02% 85.63% -1.40%
==========================================
Files 240 240
Lines 32212 32211 -1
Branches 2112 2181 +69
==========================================
- Hits 28032 27583 -449
- Misses 3248 3606 +358
- Partials 932 1022 +90 ☔ View full report in Codecov by Sentry. |
@neodescis can I merge this? I've changed the type according to your input, although I think the member itself is always full due to the extend initialization, but it's not critical, anything is better than "any" from my point of view. |
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not try it out myself, but looks good.
Sorry, I mostly don't look at these on the weekend unless I have some spare time. Next time I can approve in advance if you like! I think you're right about the extend() initialization though; sorry I missed that. |
Launch Checklist
Related:
This moves all the strings to the same place and also aligns their names.
This is basically a refactoring, but also a breaking change, so it should be part of 4.0.
The changes in public API is for the cooperative gestures configuration when initializing the map.
I have updated the relevant example.
CHANGELOG.md
under the## main
section.