Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show cooperativeGestures messages when scrollZoom is disabled #2498

Closed
htrex opened this issue May 9, 2023 · 1 comment · Fixed by #3430
Closed

Don't show cooperativeGestures messages when scrollZoom is disabled #2498

htrex opened this issue May 9, 2023 · 1 comment · Fixed by #3430
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed

Comments

@htrex
Copy link

htrex commented May 9, 2023

When scrollZoom is programmatically enabled/disabled, cooperativeGestures should behave consequently.

When using MapLibre 2.4.0 with scrollZoom disabled and cooperativeGestures enabled the map still shows the cooperativeGestures messages when the user scrolls over the map, but in that case CTRL+scrollwheel triggers the web browser page zoom, not the map zoom.
@HarelM
Copy link
Collaborator

HarelM commented May 9, 2023

Interesting. Feel free to open a PR to fix this issue.

@HarelM HarelM added bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed labels May 9, 2023
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 20, 2023
@arekgotfryd
maplibre#2498: Don't show cooperativeGestures messages when scrollZoo…
a6ad899 
…m is disabled
@arekgotfryd arekgotfryd mentioned this issue Oct 20, 2023
Closed
3 tasks
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 21, 2023
@arekgotfryd
maplibre#2498: code review remarks addressed
c7703e4
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 22, 2023
@arekgotfryd
maplibre#2498: moved logic related to cooperativeGestures to ScrollZo…
ca03be0 
…omHandler
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 22, 2023
@arekgotfryd
maplibre#2498: change some function calls + add done calls in unit tests
1f397ab
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 23, 2023
@arekgotfryd
maplibre#2498: decrease size
6c100bb
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 23, 2023
@arekgotfryd
maplibre#2498: decrease dist size
caf7f1b
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 23, 2023
@arekgotfryd
maplibre#2498: remove unused import type
1617bc3
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 24, 2023
@arekgotfryd
maplibre#2498: replace deprecated navigator.platform with navigator.u…
203437a 
…serAgent
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: remove abundant done() calls
221cc47
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: new CooperativeGestureControl
5e7aaf6
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: Don't show cooperativeGestures messages when scrollZoo…
761b470 
…m is disabled
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: code review remarks addressed
56d1f41
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: moved logic related to cooperativeGestures to ScrollZo…
ff2e47c 
…omHandler
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: change some function calls + add done calls in unit tests
9bf8675
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: decrease size
e8c9feb
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: decrease dist size
935617b
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: remove unused import type
b0a666a
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: replace deprecated navigator.platform with navigator.u…
45856c6 
…serAgent
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: remove abundant done() calls
e732569
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 25, 2023
@arekgotfryd
maplibre#2498: new CooperativeGestureControl
f02798b
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: Don't show cooperativeGestures messages when scrollZoo…
a9156dc 
…m is disabled
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: code review remarks addressed
68ba8ed
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: moved logic related to cooperativeGestures to ScrollZo…
2d2d87b 
…omHandler
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: change some function calls + add done calls in unit tests
784cbf6
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: decrease size
ddeebe1
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: decrease dist size
af5c20a
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: remove unused import type
239e94c
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: replace deprecated navigator.platform with navigator.u…
8feb7f0 
…serAgent
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: remove abundant done() calls
eaf50c5
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 26, 2023
@arekgotfryd
maplibre#2498: new CooperativeGestureControl
51e8305
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 27, 2023
@arekgotfryd
maplibre#2498: completely separated CooperativeGestureControl
6e734ce
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 27, 2023
@arekgotfryd
maplibre#2498: fix failing unit test
841a392
arekgotfryd added a commit to arekgotfryd/maplibre-gl-js that referenced this issue Oct 28, 2023
@arekgotfryd
maplibre#2498: Unsafe HTML constructed from library input - fix
3da57ef
@HarelM HarelM mentioned this issue Nov 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cooperative gestures redesign maplibre/maplibre-gl-js
2 participants
@htrex @HarelM