Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom on side globes with terrain 3D #3425

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

sbachinin
Copy link
Collaborator

Fixes #3048 (again).

Unfortunately my first solution (f99ad8c) wasn't great because:

  1. it was too complex (I've found a simpler one)
  2. it didn't solve the problem completely. The issue was still reproducible when more than one full globe was visible horizontally.

In the end the entire solution is in one line src/render/terrain.ts:345

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7b86c1) 75.60% compared to head (bd9025e) 75.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3425      +/-   ##
==========================================
- Coverage   75.60%   75.58%   -0.02%     
==========================================
  Files         242      242              
  Lines       19199    19188      -11     
  Branches     4257     4254       -3     
==========================================
- Hits        14515    14504      -11     
  Misses       4684     4684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Nov 29, 2023

Where did you find this wrap variable? Seems too good to be true :-)

@HarelM
Copy link
Collaborator

HarelM commented Nov 29, 2023

Can you add a changelog entry, in case someone will find a bug that exist in this version and does not exists in previous ones...

@HarelM HarelM merged commit 8b16a2a into maplibre:main Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map zooms to the wrong area when double clicking
3 participants