Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle loading of empty raster tiles (204 No Content) #3428

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Handle loading of empty raster tiles (204 No Content) #3428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b92bf5e
Handle empty raster tiles
petrsloup Nov 30, 2023
90cef6a
Improve `arrayBufferToImageBitmap` to handle empty buffers
petrsloup Dec 1, 2023
e5375f5
Add changelog entry
petrsloup Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

### 🐞 Bug fixes
- Fix zooming outside the central globe when terrain 3D is enabled ([#3425](https://github.com/maplibre/maplibre-gl-js/pull/3425))
- Handle loading of empty raster tiles (204 No Content) ([#3428](https://github.com/maplibre/maplibre-gl-js/pull/3428))
- _...Add new stuff here..._

## 4.0.0-pre.1
Expand Down
3 changes: 3 additions & 0 deletions src/util/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,9 @@ export function isImageBitmap(image: any): image is ImageBitmap {
* @returns - A promise resolved when the conversion is finished
*/
export const arrayBufferToImageBitmap = async (data: ArrayBuffer): Promise<ImageBitmap> => {
if (data.byteLength === 0) {
return createImageBitmap(new ImageData(1, 1));
}
const blob: Blob = new Blob([new Uint8Array(data)], {type: 'image/png'});
try {
return createImageBitmap(blob);
Expand Down