-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: order of normalizeSpriteURL and transformRequest in load sprites #3898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
==========================================
+ Coverage 87.50% 87.79% +0.28%
==========================================
Files 265 265
Lines 37970 37974 +4
Branches 2409 2402 -7
==========================================
+ Hits 33227 33339 +112
+ Misses 3665 3553 -112
- Partials 1078 1082 +4 ☔ View full report in Codecov by Sentry. |
@Kai-W can you resolve conflict and prepare this PR to be merged? I want to move forward with the breaking changes of version 5. |
transformRequest is now called once with ResourceType.Sprite and not seperatly for SpiteJSON and SpriteImage. URL validation and appending of json/png is done afterwards
I rebased the branch, but i dont know why the windows rendert test 0 is failing. @HarelM can you look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this will work well with all kind of tokens etc...
… sprites (maplibre#3898)" This reverts commit 54cf54e
This PR fixes the order of transformRequest and normalizeSpriteURL on loading Sprites.
(#3897)
Launch Checklist
CHANGELOG.md
under the## main
section.