Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev bundle should not minify #4989

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 4, 2024

Pointed out here, we're missing a flag that makes only the prod build minified.

a3f67eb#diff-1925b6790595de2a8e9305249f59ea6cc5eb109c15c6013ae09de2f30132cc7aL34

Currently, we minify the dev build as well.

terser({
compress: {
pure_getters: true,
passes: 3
},
sourceMap: true
}),

cc @NathanMOlson

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

@birkskyum birkskyum changed the title Don't minify dev build [chore] Dev bundle should not minify Nov 4, 2024
@birkskyum birkskyum changed the title [chore] Dev bundle should not minify Dev bundle should not minify Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (6eeafe9) to head (4015d64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
- Coverage   90.47%   89.27%   -1.20%     
==========================================
  Files         267      267              
  Lines       38206    38206              
  Branches     3141     2318     -823     
==========================================
- Hits        34566    34109     -457     
- Misses       2710     3101     +391     
- Partials      930      996      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum enabled auto-merge (squash) November 4, 2024 20:52
@birkskyum birkskyum merged commit 03b69f0 into maplibre:main Nov 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants