Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of maplibre-gl-draw #5086

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 21, 2024

Add example using the new maplibre-gl-draw plugin thats ported to typescript and refactored.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (40bf2b5) to head (ea3fa20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5086      +/-   ##
==========================================
- Coverage   89.07%   88.90%   -0.17%     
==========================================
  Files         269      269              
  Lines       38386    38386              
  Branches     2399     2412      +13     
==========================================
- Hits        34191    34127      -64     
- Misses       3172     3240      +68     
+ Partials     1023     1019       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

CHANGELOG.md Outdated Show resolved Hide resolved
@HarelM
Copy link
Collaborator

HarelM commented Nov 21, 2024

Looks good! Thanks!
Added a few minor comments.

@birkskyum birkskyum requested a review from HarelM November 21, 2024 07:55
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@birkskyum
Copy link
Member Author

I don't know what action to take for the codecov/project ci - it appear to break on main as well.

@HarelM
Copy link
Collaborator

HarelM commented Nov 21, 2024

I'm waiting for codecov to fix it, I have a direct line to their dev team.
Once this is solved, I'll ask Ramya to remove the codecov app and keep the comment as it was before.
It's Ok, don't worry about it.

@HarelM HarelM merged commit 94e2729 into maplibre:main Nov 21, 2024
16 of 17 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Nov 21, 2024

You can follow here if that interest you:
codecov/codecov-action#1662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants