Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macos] Missing files in platform/macos #37

Closed
rotoglup opened this issue Mar 4, 2021 · 3 comments
Closed

[macos] Missing files in platform/macos #37

rotoglup opened this issue Mar 4, 2021 · 3 comments
Labels
more info needed Further information is requested

Comments

@rotoglup
Copy link

rotoglup commented Mar 4, 2021

The current platform/macos/README.md points to the mapbox-gl-native-ios repo

If I understood correctly the current content of platform/ios/has been copied from this repo.

Should the same be done for platform/macos/, from a139216, as mentionned in the root README.md ?

@rotoglup
Copy link
Author

rotoglup commented Mar 5, 2021

If I understood correctly the current content of platform/ios/has been copied from this repo.

Should the same be done for platform/macos/, from a139216, as mentionned in the root README.md ?

FWIW, it seems that the files are there, but located in platform/ios/platform/macos.

I'm still trying to figure out how to build for macos.

@petr-pokorny-1
Copy link
Contributor

We took mapbox-gl-native-ios repo and placed it under platform/ios.
So macos stuff is under platform/ios/platform/macos platform/macos/ contains just cmake file.

When we were merging repos we were considering to move macos and ios from mapbox-gl-native-ios to the platform/macos/ and platform/ios/ to make it more intuitive but it would be necessary to rewrite the makefile and other scripts. And also move shared stuff somewhere (maybe platform/darwin)

Anyway, if you want to build for macOS, just run make xpackage from platform/ios folder.

@petr-pokorny-1 petr-pokorny-1 added the more info needed Further information is requested label Mar 5, 2021
@rotoglup
Copy link
Author

@petr-pokorny-1 Thanks for your answer, I see now that this command is mentioned in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants