-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NodeJS] Are there any plans to keep up with nodejs binaries support? #52
Comments
Node binaries of the original project stopped at Node 10, I managed to build in Node 11 but not 12. There was a fork with 12-14 bindings but I never managed to get that to work in my code. I think it would need a refactor and maybe a change of build libraries to get the bindings working? |
Here is the thread. |
I've had success with using |
I was able to get this to work on MacOS by replacing MacOS's loop system with libuv, like so:
Comment these out:
And add these:
Unfortunately though, I haven't been able to get naturalatlas to run headless in a docker container... any luck with that? |
I did a bunch of experimenting and got most things working here: https://github.com/maplibre/maplibre-gl-native/compare/master...mnutt:node-14?expand=1 It looks like the node runloop support was left behind in the build system refactoring that happened in mapbox a while back; this splits a platform-dependent runloop back out into its own cmake target. While that branch works for me, what I really wanted to do was generate prebuilt binaries and I'm having a lot of trouble paring down the dependencies; the binaries that I generate are small and have lots of linked libraries whereas the prebuilt binaries mapbox generated were quite large because they statically linked most things. My other goal with that is to completely remove the need for xvfb on headless linux, but that has a ways to go I think. |
@mnutt did you go further in this direction ? I am looking for a solution to include maplibre-gl-native in a docker image with a recent node version if possible. If no solution is available right now I am looking for the next best thing : some indication of where to dig deeper and solve the problem myself. |
Mine works fine if you are willing to build the node module as part of the docker image build: it’ll dynamically link to a bunch of things, but they’ll be available. It’s pretty far off from being to |
A lot of the work on this was completed here: #217. Last step would just be to publish the binaries and publish the package to npm to make it easy for people to |
https://github.com/maplibre/maplibre-gl-native/tree/master/platform/node
The text was updated successfully, but these errors were encountered: