Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature type unknown definition #365

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add feature type unknown definition #365

merged 1 commit into from
Oct 19, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Oct 6, 2023

This add the unknown type definition for feature - "0".
I've seen that the definition here does not conform to the spec.
I'm trying to see if I can change it in all the relevant places...

@HarelM HarelM requested a review from birkskyum October 6, 2023 19:40
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (edeaee3) 78.02% compared to head (45d3069) 78.02%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         101      101           
  Lines        4142     4142           
  Branches     1184     1184           
=======================================
  Hits         3232     3232           
  Misses        910      910           
Files Coverage Δ
src/expression/index.ts 70.10% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 5e79f67 into main Oct 19, 2023
6 checks passed
@HarelM HarelM deleted the add-unknown branch October 19, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants