Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sky in diff results #518

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Add missing sky in diff results #518

merged 5 commits into from
Feb 4, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Feb 2, 2024

Launch Checklist

Fixes #517 - Add setSky to diff results

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM HarelM requested review from birkskyum and neodescis February 3, 2024 20:54
@HarelM
Copy link
Collaborator Author

HarelM commented Feb 3, 2024

When reviewing, use "hide whitespace".
The changes in the diff test file adds readability to tests.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2009ed9) 92.22% compared to head (18a38bd) 92.23%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   92.22%   92.23%           
=======================================
  Files         100      100           
  Lines        4195     4197    +2     
  Branches     1202     1203    +1     
=======================================
+ Hits         3869     3871    +2     
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 4e9e832 into main Feb 4, 2024
6 checks passed
@HarelM HarelM deleted the add-missing-sky-diff-check branch February 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sky to diff
3 participants