rebundle node-pre-gyp and do not preinstall it
#658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests failed on Travis CI for the reasons that do not seem related. |
|
Can this be revisited and given some sort of priority? Seems a good majority of issues being made are related to this. I am sure there are a lot more people who are having issues and just not reporting them as well. |
|
my opinion: #650 (comment) |
|
Okay. However, if this issue is seen as a problem in npm, someone should report it to npm. |
It is npm/npm#12583 |
|
This is not a bug in npm, it's a misunderstanding of how npm is supposed to work. There's no reason the install command should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts df7d542 to prevent an endless loop in npm v3.
Fixes #650, #640, #630.