Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor our Handlebars helper logic into the Backbone view #438

Closed
modulitos opened this issue Sep 9, 2016 · 0 comments
Closed

Refactor our Handlebars helper logic into the Backbone view #438

modulitos opened this issue Sep 9, 2016 · 0 comments
Assignees

Comments

@modulitos
Copy link
Member

In PR #435 we added lots of extra logic into our each_place_item Handlebars Helper, shown here: https://github.com/smartercleanup/platform/pull/435/files#diff-84b7065ac0f6c9065befa0b524ce0d81L174

Perviously, that helper was making minor changes to the context passed from our place-detail view into our place-detail template. But with our new dynamic forms feature, we need to make a lot more changes to the context as we pass it into our template. Thus, we added a lot more pre-processing logic via #435, and the each_place_item helper method has become quite long. We should try and move that method into our view, and be explicit that it is performing a pre-processing task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants