Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 legacy config with key vault and managed service identity crashes with NullReferenceException #484

Closed
idg10 opened this issue Jan 18, 2023 · 0 comments · Fixed by #485
Closed

V2 legacy config with key vault and managed service identity crashes with NullReferenceException #484

idg10 opened this issue Jan 18, 2023 · 0 comments · Fixed by #485
Assignees
@idg10

Comments

@idg10
Copy link
Contributor

idg10 commented Jan 18, 2023

Services previously deployed with v1 of Marain.Tenancy may end up with tenants whose storage configuration relies on reading from a key vault without specifying the identity with which to connect to Key Vault. The correct behaviour in this case is to use the managed service identity.

The Corvus.Storage code correctly attempts that, but it relies on the host process having supplied an implementation of IServiceIdentityAzureTokenCredentialSource via DI. Marain.Tenancy currently fails to do this, leading to crashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idg10 idg10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Register IServiceIdentityAzureTokenCredentialSource in DI marain-dotnet/Marain.Tenancy
1 participant
@idg10