Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set the "ID" of a mash sketch #87

Closed
tseemann opened this issue Jun 11, 2018 · 7 comments
Closed

Option to set the "ID" of a mash sketch #87

tseemann opened this issue Jun 11, 2018 · 7 comments

Comments

@tseemann
Copy link
Contributor

tseemann commented Jun 11, 2018

I want my IDs to be neat, but mash is making it hard?

Case 1:

mash sketch -r -o foo DIR/R1.fq.gz
mash info foo.msh

  [Hashes]  [Length]  [ID]            [Comment]
  1000      105082    DIR/R1.fq.gz  - 

Case 2 (see closed #32)

cat R1.fq.gz R2.fq.gz  | mash sketch -r -o foo -
mash info foo.msh

 [Hashes]  [Length]  [ID]  [Comment]
  1000      1253918   -      -

I would just like a -n or -I option to set the [ID].

And the [Comment] ?

@ondovb
Copy link
Member

ondovb commented Sep 21, 2018

Implemented as -I and -C (comment).

@tseemann
Copy link
Contributor Author

tseemann commented Oct 6, 2018

@ondovb I can't see any commits in master that refer to this?

Any chance of a 2.1 release for this feature?

Currently doing crazy named pipe setups to get proper IDs because when I do <(zcat R1 R2) i get the same name on everything /dev/fd/63.

@tseemann
Copy link
Contributor Author

tseemann commented Oct 6, 2018

UPDATE: i see it's in the triangle mod. Triangle does not work with the tools I have. It will need to be a full matrix, sorry.

@ondovb
Copy link
Member

ondovb commented Oct 7, 2018

It's in 03b28ed, which addresses both the ID issue and the read pair merging (I labelled round robin since it takes turns pulling reads from the input files to preserve -c, which I don't think anyone uses anyway :P ).

It's only part of the sketch command so it shouldn't matter whether you use dist or triangle
following that. Setting IDs directly in those would be possible but a little trickier parameter-wise.

Hopefully I'll get a release out soon but I want to make sure it's stable since there are some sketching changes. If you manage to break something in tip that would be helpful :).

@ondovb
Copy link
Member

ondovb commented Oct 7, 2018

Ok, published v2.1.

@tseemann
Copy link
Contributor Author

tseemann commented Oct 7, 2018

Thanks @ondovb - I am going to run it now on 25,000 isolates. Will let you know what happens.

@ondovb
Copy link
Member

ondovb commented May 1, 2019

This seems fixed? Reopen if not.

@ondovb ondovb closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants