From c861f121ab72c5cc3711d687060a3dc8647038aa Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Wed, 8 Nov 2023 15:44:31 +0000 Subject: [PATCH] Bug 1859941 [wpt PR 42619] - Change expectation for invalid/missing shadowRootMode IDL to null, a=testonly Automatic update from web-platform-tests Change expectation for invalid/missing shadowRootMode IDL to null Per the spec discussion: https://github.com/whatwg/html/pull/5465#discussion_r1360590511 this changes the expectation for the tests to be: document.createElement("template").shadowRootMode === "" rather than === null. Note that this CL does not change Chromium's behavior, and as such I cannot check if there are other tests that implicitly also do a similar check. More tests might need to change once I (or someone) implements this new behavior in a browser. Bug: 1379513 Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120 Commit-Queue: Mason Freed Auto-Submit: Mason Freed Reviewed-by: Joey Arhar Cr-Commit-Position: refs/heads/main{#1213658} -- wpt-commits: af6cbc76339f4d2bd67bcee8e1d9b3be879853eb wpt-pr: 42619 UltraBlame original commit: 36bafbbc0d89633570c02ee499f4ae40db42c4b0 --- .../declarative/declarative-shadow-dom-basic.html | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/testing/web-platform/tests/shadow-dom/declarative/declarative-shadow-dom-basic.html b/testing/web-platform/tests/shadow-dom/declarative/declarative-shadow-dom-basic.html index 578cf7d49e6fb..07c91983af10b 100644 --- a/testing/web-platform/tests/shadow-dom/declarative/declarative-shadow-dom-basic.html +++ b/testing/web-platform/tests/shadow-dom/declarative/declarative-shadow-dom-basic.html @@ -479,13 +479,15 @@ t . shadowRootMode -null +' +' ' Invalid values map to -null +empty +string ' ) ; @@ -503,14 +505,16 @@ t . shadowRootMode -null +' +' ' No shadowrootmode attribute maps to -null +empty +string ' ) ;