module: fix crash when built-in module export a default key

PR-URL: nodejs#51481 Fixes: nodejs#51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
marco-ippolito · Jan 22, 2024 · f7c0be2 · f7c0be2
1 parent 7880ca6
commit f7c0be2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/internal/bootstrap/realm.js b/lib/internal/bootstrap/realm.js
@@ -350,7 +350,9 @@ class BuiltinModule {
     const url = `node:${this.id}`;
     const builtin = this;
     const exportsKeys = ArrayPrototypeSlice(this.exportKeys);
-    ArrayPrototypePush(exportsKeys, 'default');
+    if (!ArrayPrototypeIncludes(exportsKeys, 'default')) {
+      ArrayPrototypePush(exportsKeys, 'default');
+    }
     this.module = new ModuleWrap(
       url, undefined, exportsKeys,
       function() {

diff --git a/test/parallel/test-process-default.js b/test/parallel/test-process-default.js
@@ -0,0 +1,8 @@
+'use strict';
+const common = require('../common');
+const assert = require('node:assert');
+
+process.default = 1;
+import('node:process').then(common.mustCall((processModule) => {
+  assert.strictEqual(processModule.default.default, 1);
+}));