-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOTK: Feature request: Add pins to map #183
Comments
Upvoting this ngl |
Marking these in map is the only feature I'm interested myself. So I will work on that for sure at some point. ...unless someone does the RE dirty work before and dumps the savegame hash table and korok locations. Then I should be able to port this feature from BOTW editor easily. |
Upvoting! |
Someone has finished all koroks there's 1000. Anyway they could help with the korok thing here? |
Upvoting too! |
Also, there's more places that should be pinned now, such as caves, wells, lightroots, crystallized charges, bubbul gem, schematics, old maps, etc |
Already starting to work on this ;-) Though don't expect an update on this anytime soon, still need to do a little bit more of research. |
That's a zoom meet link. If it was really posted there, I can't read the older messages :-/ |
Oh no, please ignore that link, this is the correct one for the hashes: https://gbatemp.net/threads/zelda-tears-of-the-kingdom-152-shirne-120-tree-800-korok-save.633097/#post-10164724 |
Unfortunately, that's the hashed keys, what we need to make everything easier is the original key values. And another thing... That list was probably extracted from And anyway... Even if it was correct, that would only allow us to get the korok seeds instantly. What are we looking for is to add pins to the map so we can obtain korok seeds legitly. I've got the coordinates already (which, in this case, it's exactly 900!), what I am missing now is the relationship between the coordinates and their boolean values in the hash table. |
Got some news! |
Well hopefully somebody will tie things together, the most I've found is a little more info in the Banc\MainField*_Static.bcett.byml.zs files For example J-4_Static.bcett.byml.zs has a location to release korok and this Hash/Placement ID is found in GameData/GameDataList.Product.100.byml:
Then right after that in the file there is this entry where the korok appears on the map after freed:
The above placement value is what appears in Banc\MainField\HiddenKorok\MainField.hiddenkorok.byml.zs |
Added pin to map for shrines and lightroots! |
I just finished getting all koroks in the game. If it helps with anything let me know what you would need. |
@Karlos007 I've seen by coincidence you've filtered the valid korok seed flags. Amazing job. Do you mind if we use them in the editor? |
Yeah you can use them, It took some time but I wanted to discover the 83 invalid flags |
Wow Also, in current version of the totk editor, doesn't seem possible to mark only the missing Koroks, just 3 sets of 300 of them. Is this a technical limitation or may be possible in future to set just the missing ones? |
It would be awesome if it also adds Light of Blessing to player's inventory when the shrines are cleared. |
Added pin to map missing koroks!!!
That will come, but please give me some time 😅 |
You can also use the editor to add light of blessings to your key items |
Made it so it adds automatically korok seeds and light of blessing after setting korok and shrines to complete. |
I got the coordinates from the game files (which are indeed the seed icon that appears when you find a korok), so that's why they appear there. In order to show the starting position icons, someone should compile the real starting coordinates manually and sort them correctly matching the game order. That sounds like a time consuming task. |
i'd definitely like the frog pin function as well (also need to close out the request i created just now) |
Pins for undefeated mini-bosses would also be appreciated, as medals are also here in this game. |
The game marks in the map the wells you'd visited, then probably it can be done the same way as the korok seeds (getting these mark locations) |
It may not be possible since the locations do not seem to be stored in the map coordinates, but a similar feature to pin sages wills would be great. |
Added bosses locations. |
Added caves, wells and bubbuls. |
I'll test it tonight. :) |
Is there already a list with the location of all the chests? (well that's something I've always wanted in BotW editor too lol) |
They don't have the coordinates saved in the game unfortunately, but sites online have helpfully listed the exact in-game coordinates of the locations for Sage's Wills. Every single ambient treasure chest though... that would be a lot. I don't think there are enough pins. 300+ chests almost certainly exist. |
Online sites do have the location of all the chests (all the fixed ones) We also don't need to tag them all at once, so it's okay to have more than 300. Koroks even have 900. The secret is to tag only what isn't caught until you complete the pins. Then the user plays the game, takes several of them and uses again the editor to mark new ones. Works wonderfully for keeping track of koroks. |
The biggest advantage of the implementation, in fact, involves being able to pin these chests and filter the ones you have already taken by the save editor. When I refer to list, I mean a list of coordinates/locations in memory. Like what is being done at: I'm sure that at least a list of coodinates exists, as many websites show all the chests in interactive maps. |
True. As you stated, there are plenty of sites listing the raw coordinates of the chest locations and items like the Sage's Wills. So there's a good chance if it is possible to convert those into the same format the in-game map uses, those could then be mappable to the in-game map as well. Honestly incredible we've come so far in just a few weeks since release. Incredible work. I think Sage's Will's might remain as a feature to be implemented this way. As well as any specific armor set locations if the editor wants to go that far. |
Sage's Will locations (coordinates):
|
Hudson Signs: -0758, 0238, 0018 |
If you go to https://objmap-totk.zeldamods.org/ , click magnifying glass and search for "Sage's Will" you'll get a list of 20 chests. I copied it out though just in case it help, but it is probably better just to parse the json yourself into the format you need.
By the way made that database using this github https://github.com/zeldamods/radar-totk/ Could be used for the other stuff as well like Hudson Signs. |
I've changed my PR to implement Sage's Wish locations to use these converted coordinates. But I have no clue about how to convert these memory locations for a 8-byte standard. |
|
|
|
At this point, I think everything has been done in this feature. Is it missing anything? |
Adding unlocking all recipes (with all alternative recipes for each ones) would be nice also |
Don´t know if it´s possible, but quest giver locations would be nice. Also Chests with Armor inside?
Does it mean icon locations like Crystal Refinery or Lookout Landing or written map locations like Temple of Time? |
In the course of my testing, a question arose: |
"Locations" meant the text that appear on the map when you discover a place (like temple of time) |
yes this is one I'd love. Especially for the caves that have those special clothing chests in them. Side quest/side adventure locations would also be great as well. |
Did you ever look into adding pins for quest locations? |
Expected feature:
The TOTK savegame editor can modify koroks seeds, visited locations, and defeated bosses in the game, and mark them as finished or mark locations on the in-game map, as is done in the BOTW savegame editor.
Sorry to bother you, but these features are great for saving time (especially the koroks seeds, of which there are so many). I would appreciate it if you could include these features in the editor.
PS: I've noticed that someone has already mentioned the related request in #164, but you said that a new issue should be created for the request.
The text was updated successfully, but these errors were encountered: