Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unittests #34

Open
ClasherKasten opened this issue Sep 24, 2022 · 4 comments · Fixed by #46
Open

Adding unittests #34

ClasherKasten opened this issue Sep 24, 2022 · 4 comments · Fixed by #46
Labels
hacktoberfest Label for Hacktoberfest issues

Comments

@ClasherKasten
Copy link
Collaborator

ClasherKasten commented Sep 24, 2022 •
edited
Loading

There are not really tests in this repository which makes it a bit hard to ensure there are no bugs and/or unintentional behavior.

To fix this, unittests should be written.
When this is done, integration tests can be done too.

Right now there is only one (unnecessary) test.
All new tests should be created in a new directory called tests/ and because it is already in use, pytest should be used as test-framework.
@ClasherKasten ClasherKasten added the hacktoberfest Label for Hacktoberfest issues label Sep 24, 2022
@GrbavaCigla
Copy link
Contributor

Hi, I am want to solve this, can you assign me?

@GrbavaCigla GrbavaCigla mentioned this issue Oct 8, 2022
Merged
@ClasherKasten ClasherKasten changed the title Adding tests Adding unittests Oct 8, 2022
@programmin1
Copy link
Contributor

Looks good, do you need more tests created?
Interesting project!

@ClasherKasten
Copy link
Collaborator Author

Looks good, do you need more tests created?
Interesting project!

First: Nice that you find this project interesting. 👍

#46 already covers many parts of the code, but it definitely does not cover everything. So new PRs fixing that would be very welcome.

@ClasherKasten ClasherKasten reopened this Oct 12, 2022
@programmin1
Copy link
Contributor

Ok check out #50 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Label for Hacktoberfest issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added test, pytest configuration, removed unnecessary import
3 participants
@programmin1 @GrbavaCigla @ClasherKasten