Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with add link URL control #467

Open
liadbe opened this issue May 7, 2019 · 6 comments
Open

Issues with add link URL control #467

liadbe opened this issue May 7, 2019 · 6 comments

Comments

@liadbe
Copy link

liadbe commented May 7, 2019

Hi, 2 issues we encountered with the add link control:

  1. It is not possible to copy text from the input of the url (neither ctrl+c or _right-click).
  2. If URL prefix (https://) is not entered, it automatically adds the domain name before the URL entered in the link . We solved it using the link hook.

Thanks,
Liad

@margox
Copy link
Owner

margox commented May 10, 2019

Confirmed, I will fix the first issue soon.

@liadbe
Copy link
Author

liadbe commented Jun 19, 2019

Hi,
Regarding the 1st issue, now when I try to copy the URL (e.g. https://google.com), it copies the text of the URL instead (e.g. visit Google).
Worth mentioning I am not using allowInsertLinkText (by default it's false).

@margox
Copy link
Owner

margox commented Jun 19, 2019

@liadbe I will take a look tomorrow. I just noticed that this problem does not exist in react-draft-wysiwyg, so it should be repairable.

@margox
Copy link
Owner

margox commented Jun 20, 2019

Hi, I just published v2.3.7 and this issue should be fixed :)

@liadbe
Copy link
Author

liadbe commented Jul 22, 2019

Hi, I thought this issue is behind us. But something weird is happenning, these are the steps to reproduce:

  1. Select text inside the editor and click the 'add link' control
  2. Insert url without url prefix (https://), for example - google.com
  3. Select the linked text in the editor
  4. Press right click -> Copy link address
  5. See that the address copied is not just google.com but with added prefix (probably your domain)

Can u please have a look on that?

Thanks.

@margox
Copy link
Owner

margox commented Jul 22, 2019

The editor won't apply any protocol by default, so you input google.com, for browser, it's just a relative path, you can have a try on any website, find a link and remove the prefix of it by using the browser development tool, then right click the link and copy the url of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants