-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deriving some common traits + defmt feature and no_std
support
#2
Comments
no_std
no_std
support
I will definitely try to migrate the traits provided by As to the dependencies, I've never actually written a crate with feature flags, although I imagine it is not difficult. I will begin working on this once my studies become less difficult. |
That's great! Good luck with your studies. Do let me know if you need some assistance. |
Done. Core traits added with 4e985e5 Unfortunately due to not being able to enable features for tests (which is currently being discussed here), I could not verify the functionality of the defmt feature working. Given how simple the derive was, I imagine it works fine. |
Yaay! Btw for MSRV you can add "rust-version" to Cargo.toml |
In addition to the current Debug derive of
IbusPacket
andParsingError
it would be nice to have Clone/Copy anddefmt::Format
(enabled with a features as an optional dep.) to be used inno_std
environment.To support
no_std
we can usecore::error::Error
(which is stable since1.81
) so either a MSRV should be added orstd::error::Error
impl should be enabled only with a feature, e.g.std
feature.core::fmt::Display can be used instead of the std::fmt::Display to support
no_std
The text was updated successfully, but these errors were encountered: