Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component update - Select - refactoring and b2b design update #1648

Closed
andres-dediego2 opened this issue Jan 17, 2022 · 3 comments
Closed

Component update - Select - refactoring and b2b design update #1648

andres-dediego2 opened this issue Jan 17, 2022 · 3 comments
Labels
status:ready Ready for development type:design design

Comments

@andres-dediego2
Copy link

andres-dediego2 commented Jan 17, 2022 •
edited by ti10le
Loading

Description

Correctction to the select component:
The hight size is 40px instead of 32px. The focus color and the selection color changed to orange for the B2B Theme.
Figma Link: https://figma.fun/443YqC

Context

Fixing the color Palete to the Theme, as well to making the dropdowns mobile friendly and having the same dimensions.

Consequences

It will be easier to select and read, as well it will be an homogeneous theme.
@andres-dediego2 andres-dediego2 added the status:rfc New issue that requires discussion and finalization label Jan 17, 2022
@ti10le ti10le added type:feature New feature or component type:design design and removed type:feature New feature or component labels Jan 17, 2022
@ti10le ti10le changed the title Select Component - Select refactoring and b2b design update Jan 25, 2022
@ti10le ti10le changed the title Component - Select refactoring and b2b design update Component update - Select refactoring and b2b design update Jan 25, 2022
@ti10le ti10le changed the title Component update - Select refactoring and b2b design update Component update - Select - refactoring and b2b design update Jan 25, 2022
@ti10le ti10le added status:ready Ready for development and removed status:rfc New issue that requires discussion and finalization labels Jan 28, 2022
@ti10le
Copy link
Contributor

ti10le commented Feb 10, 2022

@all-contributors please add @andres-dediego2 for design, doc

@allcontributors allcontributors bot mentioned this issue Feb 10, 2022
Merged
@allcontributors
Copy link
Contributor

@ti10le

I've put up a pull request to add @andres-dediego2! 🎉

@sebald
Copy link
Member

sebald commented May 3, 2022

Closed via #2048

@sebald sebald closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready Ready for development type:design design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebald @andres-dediego2 @ti10le