Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Content Components #1996

Closed
7 tasks done
sebald opened this issue Apr 14, 2022 · 0 comments
Closed
7 tasks done

Create new Content Components #1996

sebald opened this issue Apr 14, 2022 · 0 comments
Labels
status:ready Ready for development
Milestone

Comments

@sebald
Copy link
Member

sebald commented Apr 14, 2022

Description

We want to create some components that can be used to organize content.

Components

CONTENT

Context

We decided to steal the idea from react-spectrum and create reusable components that help structure content instead of creating dedicated components for things like <Card> and <Dialog>.

Consequences

Instead of having something like this:

<Card>
  <Card.Title></Card.Title>
  <Card.Content></Card.Content>
  <Card.Footer></Card.Footer>
</Card>

<Dialog>
  <Dialog.Title></Dialog.Title>
  <Dialog.Content></Dialog.Content>
  <Dialog.Footer></Dialog.Footer>
</Dialog>

we want this:

<Card>
  <Header></Header>
  <Content></Content>
  <Footer></Footer>
</Card>

<Dialog>
  <Header></Header>
  <Content></Content>
  <Footer></Footer>
</Dialog>

This should help to enforce consistency in the design, e.g. same heading everywhere.

@sebald sebald added status:rfc New issue that requires discussion and finalization status:ready Ready for development and removed status:rfc New issue that requires discussion and finalization labels Apr 14, 2022
@sebald sebald added this to the 🔖 1.0 milestone Apr 14, 2022
@sebald sebald closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready Ready for development
Projects
None yet
Development

No branches or pull requests

1 participant