Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design update - Slider #835

Closed
ti10le opened this issue Mar 2, 2021 · 8 comments · Fixed by #1313
Closed

Design update - Slider #835

ti10le opened this issue Mar 2, 2021 · 8 comments · Fixed by #1313
Assignees
@ti10le
Labels
status:ready Ready for development type:design design type:feature New feature or component

Comments

@ti10le
Copy link
Contributor

ti10le commented Mar 2, 2021 •
edited
Loading

Current Version:

  • simple Slider component with variant prop

-> Figma Design

Todo:

  • add variant for Slider to show: default, active and disabled
@ti10le ti10le added the type:design design label Mar 2, 2021
@ti10le ti10le added type:feature New feature or component status:rfc New issue that requires discussion and finalization labels Apr 12, 2021
@ti10le ti10le added status:ready Ready for development and removed status:rfc New issue that requires discussion and finalization labels Apr 26, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@ti10le ti10le self-assigned this Sep 14, 2021
@ti10le
Copy link
Contributor Author

ti10le commented Sep 14, 2021

Added styles for firefox and webkit (chrome, safari, opera). One problem is that theres no webkit support for progress styling (the styles left from the thumb) like firefox or IE. See here...

@ti10le
Copy link
Contributor Author

ti10le commented Sep 14, 2021 •
edited
Loading

firefox: (this is how it should be in all browsers)
image

chrome:
image

@ti10le ti10le mentioned this issue Sep 14, 2021
Merged
@ti10le
Copy link
Contributor Author

ti10le commented Sep 14, 2021

I would say the problem is currently too small to invest so much extra time in it. What do you think @viktoria-schwarz @sebald?
More info at my Draft PR

@ti10le
Copy link
Contributor Author

ti10le commented Sep 27, 2021

What do you think about this @sebald @viktoria-schwarz ?

@sebald
Copy link
Member

sebald commented Sep 27, 2021

Will look into it this week

@sebald
Copy link
Member

sebald commented Nov 29, 2021

let's merge and add a bug report for chrome?

@ti10le
Copy link
Contributor Author

ti10le commented Nov 29, 2021

Ok 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ti10le ti10le

Labels
status:ready Ready for development type:design design type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(comp): Slider component - design update marigold-ui/marigold
2 participants
@sebald @ti10le