Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safer check before removing session #3838

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Feb 18, 2025

With multiple clients. It's possible they try to remove each other at the same time from different callsites, so this adds an extra check

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:06pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:06pm

@mscolnick mscolnick force-pushed the ms/remove-session-check branch from 9410f0d to b250cdf Compare February 18, 2025 20:04
@mscolnick mscolnick merged commit 70a6d64 into main Feb 18, 2025
30 of 34 checks passed
@mscolnick mscolnick deleted the ms/remove-session-check branch February 18, 2025 20:17
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.7-dev11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant