refactor: migrate VariableName to use NewType #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Myles Scolnick <myles@marimo.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
for more information, see https://pre-commit.ci
Co-Authored-By: Myles Scolnick <myles@marimo.io>
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.7-dev13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate VariableName to use NewType
This PR migrates the
VariableNametype from a plainstrto useNewType("VariableName", str)for better type safety. This is part of the ongoing effort to improve type safety in the codebase.Changes
VariableNamein_types/ids.pyto useNewTypeTesting
hatch run typecheck:check)hatch run lint)Link to Devin run: https://app.devin.ai/sessions/e1ee00a6fb4e476aa91c3e7fca16a501
Requested by: Myles