Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the DataImportAPI.java #162

Open
cklee1967 opened this issue Jan 26, 2021 · 0 comments
Open

Bug in the DataImportAPI.java #162

cklee1967 opened this issue Jan 26, 2021 · 0 comments

Comments

@cklee1967
Copy link

at Line 48:
@OverRide
public ImportExecution importFromFile(ImportConfiguration importConfiguration, FileDescriptor fileToImport, Map<String, Object> defaultValues) throws FileStorageException {
return importFromFile(importConfiguration, fileToImport, Collections.emptyMap(),null);
}

I think the “Collections.emptyMap()” should be “defaultValues”.

@OverRide
public ImportExecution importFromFile(ImportConfiguration importConfiguration, FileDescriptor fileToImport, Map<String, Object> defaultValues) throws FileStorageException {
return importFromFile(importConfiguration, fileToImport, defaultValues,null);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cklee1967