-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--from
, --to
and --at
using milliseconds is confusing
#19
Comments
Could you provide the commands you tried and the uploaded asciicast you are using? |
Also see #18 (comment) |
Thanks for the example in #18. Helped me to figure out my mistake. Is there a way we can prevent future users make the same mistake? |
I think |
I chose milliseconds to avoid confusion with floating point delimiters and give fine grained control. I'm leaning towards keeping it this way. The problem with the warning you suggest is that it would trigger for legit use, e.g cases where I wanted everything in the cast, except a few frames at the start
Expanding the time-related flag to support
|
I like the second idea! |
--from
, --to
and --at
don't seem to work--from
, --to
and --at
using milliseconds is confusing
Jep, let's do this. Want to lend a hand? |
Ok. I'll open a pull request |
@adius Are you still interested in this? |
Yes, sorry, have to do some other things first. Finish it next week |
Maybe just support the standard for time format, ISO8601/Times. It says seconds and fractions of a second are standard. And that both a dot and a comma are ok for a delimiter. Actually, there must be a library function that supports the standard. No need to code this from scratch. |
No matter what values I enter I always just get the initial view and nothing happens.
The text was updated successfully, but these errors were encountered: