-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for asciicast 'idle_time_limit' #30
Comments
Jep, sounds like a good idea. Want to lend a hand? |
It's as good an excuse as any to learn some more Javascript, I can have a poke around soon hopefully. |
👍 That is very nice of you, thanks! You'll want to have a look at the following lines that start the Lines 469 to 475 in e22ca85
They'll look something like: const result = await execa("asciinema", [
"rec",
"-c",
cmd,
...(options.title ? ["-t", options.title] : []),
...(typeof options.maxWait === number ? ["--max-wait", options.maxWait] : [])
tmp
]); This changes also requires the addition of
record(cli.flags.command, {
maxWait: typeof cli.flags.maxWait === "number" ? cli.flags.maxWait * 1000 : cli.flags.maxWait
}) |
I was actually talking about using a json file recorded by asciinema itself. But I see that tying it in here would be useful. I reported a similar issue here: asciinema/asciicast2gif#34 Maybe if https://github.com/marionebl/load-asciicast pulled it's submodule of asciiema-player up to v2.6.1 then at least the json might work. This is all hearsay and suspicion as I have not got the build environment set up here yet, so pinch of salt required. |
Ok, that is interesting. Could you point to an |
Yep, here is one (that I added to the other issue) |
Also I tried again today (reinstall from npm) and I assume that pulling the submodules up in the other repo has fixed this. It works great now. Feel free to close this unless you want to keep it open for adding CLI support for this feature? |
As long as you update load-asciicast library to use latest asciinema-player it will automatically handle Btw, I've set up a discussion forum for asciinema: https://discourse.asciinema.org/ , where I'd be happy to discuss this and any other asciinema/asciicast related topics 👋 |
Asciicast version 2 files have a setting for 'idle_time_limit'. This is meant to compresses time differences bigger than the set amount. It is handy for making clean demos. svg-term-cli is not respecting that field currently.
The text was updated successfully, but these errors were encountered: