-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: hover for variables #309
Conversation
Hey @kyklish , is there a reason this is still a draft? |
It's quick I did not test it, like I should. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also try to add the internal/external logic we have in formatter. Let's get the list of variables from the document cache and then send it to a helper function that takes a list of variables and a variable name and returns the first variable that matches the provided name. We'll call the helper with one file at a time to avoid performance issues with larger projects.
Similarly for ahkHoverProvider.ts
, let's try to add unit tests to the return value of the modified function.
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
Would it be possible to do this for labels too? |
Closes #289.
Now, working only for global variables (vars inside functions are without hover).
Notifying @mark-wiemer