Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support older VS Code versions #574

Closed
tycode opened this issue Nov 18, 2024 · 4 comments · Fixed by #576
Closed

Please support older VS Code versions #574

tycode opened this issue Nov 18, 2024 · 4 comments · Fixed by #576
Assignees
Labels
enhancement new feature or request good first issue good for new contributors

Comments

@tycode
Copy link

tycode commented Nov 18, 2024

Hi!

I am stuck on VS Code v1.91.x due to microsoft/vscode#224515. MS doesn't seem to be in a hurry to resolve this, so I expect this to remain the case for the foreseeable future.

So my VS Code will not install ahkpp newer than 6.1.1.

I noticed this extension bumped the required VS Code version from 1.90.x to 1.93.x in c3adca4... which claims to be #527... which provides no further context but I assume it's talking about merging the functionality from thqby/vscode-autohotkey2-lsp.

Yet that repo's package.json, atow, only requires VS Code 1.82.0, as seen here.

My guess is that your bump wasn't actually necessary - if it's just a case of changing the number back and submitting a patch release to the marketplace, can you please do so?

FWIW, I'm here due to #493. I'm on Linux using AHK_X11, so AHK2 is irrelevant to me and what I'm really after is to get rid of the "select interpreter" popup. Funnily enough, ahkpp actually misinterprets some of my (very small) AHK1 scripts as AHK2 scripts; if there's a way to tell it I only want AHK1 support in general, that'd be pretty fantastic, too.

@mark-wiemer
Copy link
Member

Hi, I'll see what I can do. As I'm away from vacation, I suggest you install the latest version 5.x in the short term to get rid of that popup. Sorry for the inconvenience. Ref https://github.com/mark-wiemer-org/ahkpp/blob/main/docs/Troubleshooting.md#install-specific-version-of-ahk

@mark-wiemer mark-wiemer added enhancement new feature or request good first issue good for new contributors labels Nov 22, 2024
@mark-wiemer mark-wiemer moved this to Todo in AHK++ Nov 22, 2024
@tycode
Copy link
Author

tycode commented Nov 24, 2024

Thanks, I can confirm installing 5.0.7 (the latest 5.x that showed for me) does indeed get rid of the popup.

Sadly VS Code then displays a badge complaining that I have extensions that could be updated, which is more distracting than the popup... so I'll stick to the latest version for now. (It really should not count manually-downgraded extensions towards the number of updatable extensions, imo - this is definitely not your issue, though. I might raise this upstream some day...)

The popup really isn't any trouble for me so don't worry about that. I raised this issue proactively from the POV of "version requirements shouldn't be bumped for no reason" rather than anything else (and if there is a good reason, i.e. "requires this new feature", then documenting that in the release notes or commit message etc. would have been fine). I'm in no rush. :)

@mark-wiemer
Copy link
Member

You are right. I remember wanting a new feature, but I can re-evaluate. Just give me another week ;)

@mark-wiemer
Copy link
Member

Reducing the requirements back down to VS Code 1.68 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request good first issue good for new contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants