Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable syntax highlighting #84

Closed
mark-wiemer opened this issue Apr 22, 2021 · 4 comments
Closed

Add option to disable syntax highlighting #84

mark-wiemer opened this issue Apr 22, 2021 · 4 comments
Assignees
Labels
enhancement new feature or request syntax highlighter syntax highlighter (code coloring) issues wontfix this will not be worked on

Comments

@mark-wiemer
Copy link
Member

Is your feature request related to a problem? Please describe.
Syntax highlighting in this extension isn't good, but many other features are. I want to combine this extension with another, but they clash on syntax highlighting so I can't.

Describe the solution you'd like
Ideally I can disable syntax highlighting from this extension, and enable another extension specifically for syntax highlighting. That way, I can have great syntax highlighting plus all the other features of AHK++.

Bonus: Just fix the syntax highlighting of AHK++ ;)

Describe alternatives you've considered
Trying to enable and disable extensions as needed is possible, but very clunky.

Additional context
See Use this extension along with "AutoHotKey2 Language Support" by thqby for syntax error highlighting · Discussion #75 · mark-wiemer/vscode-autohotkey-plus-plus

@mark-wiemer mark-wiemer added the enhancement new feature or request label Apr 22, 2021
@mark-wiemer mark-wiemer self-assigned this Apr 22, 2021
@mark-wiemer mark-wiemer added this to the May 2021 milestone Apr 22, 2021
@mark-wiemer mark-wiemer modified the milestones: May 2021, vNext May 30, 2021
@mark-wiemer mark-wiemer added the syntax highlighter syntax highlighter (code coloring) issues label Jun 11, 2022
@mark-wiemer
Copy link
Member Author

Closing this as the discussion that started it (#75) didn't want this extension to be disabled, but wanted this extension to take priority over another.

If anyone wants this feature, feel free to open a new issue or comment here asking me to re-open this one :)

@mark-wiemer mark-wiemer added the wontfix this will not be worked on label Jun 11, 2022
@alfredomtx
Copy link

@mark-wiemer

comment here asking me to re-open this one :)

I would love to have this option, I also found another extension with better highlighting(https://github.com/CoffeeChaton/vscode-autohotkey-NekoHelp) and unfortunately ahkpp takes precedence over this one :/

@mark-wiemer mark-wiemer reopened this Jun 10, 2023
@mark-wiemer mark-wiemer removed the wontfix this will not be worked on label Jun 21, 2023
@mark-wiemer mark-wiemer pinned this issue Jun 21, 2023
@mark-wiemer
Copy link
Member Author

Not closing, but deprioritizing this one as I look at other's with more impact. Please let me know what syntax highlighting issues are most pressing -- NekoHelp is licensed under LGPL so I should be able to copy-paste any code from there to improve this project :)

@mark-wiemer mark-wiemer unpinned this issue Aug 4, 2023
@mark-wiemer mark-wiemer moved this to Todo in AHK++ Aug 18, 2024
@mark-wiemer
Copy link
Member Author

Closing as low priority. I may come back to this, but it's very hard to make this extension toggle syntax highlighting, and the best approach I can think of is offering a non-highlighting version, but that would be awkward. Ultimately I'd recommend folks to let me know where the highlighting is lacking so I can improve AHK++ itself :)

@mark-wiemer mark-wiemer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in AHK++ Oct 18, 2024
@mark-wiemer mark-wiemer added the wontfix this will not be worked on label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request syntax highlighter syntax highlighter (code coloring) issues wontfix this will not be worked on
Projects
Status: Done
Development

No branches or pull requests

2 participants